Skip to content

Commit

Permalink
gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector…
Browse files Browse the repository at this point in the history
…_init()

[ Upstream commit ef8886f ]

A NULL check for bridge->encoder shows that it may be NULL, but it
already been dereferenced on all paths leading to the check.
812	if (!bridge->encoder) {

Dereference the pointer bridge->encoder.
810	drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);

Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220727073119.1578972-1-zengjx95@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
linuszeng authored and gregkh committed Oct 21, 2022
1 parent 5121d04 commit 912f84e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/gpu/drm/bridge/lontium-lt9611.c
Original file line number Diff line number Diff line change
Expand Up @@ -813,13 +813,14 @@ static int lt9611_connector_init(struct drm_bridge *bridge, struct lt9611 *lt961

drm_connector_helper_add(&lt9611->connector,
&lt9611_bridge_connector_helper_funcs);
drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);

if (!bridge->encoder) {
DRM_ERROR("Parent encoder object not found");
return -ENODEV;
}

drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);

return 0;
}

Expand Down

0 comments on commit 912f84e

Please sign in to comment.