Skip to content

Commit

Permalink
f2fs: drop inplace IO if fs status is abnormal
Browse files Browse the repository at this point in the history
If filesystem has cp_error or need_fsck status, let's drop inplace IO
to avoid further corruption of fs data.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
  • Loading branch information
chaseyu authored and Jaegeuk Kim committed Apr 26, 2021
1 parent 8af85f7 commit 9557727
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion fs/f2fs/segment.c
Original file line number Diff line number Diff line change
Expand Up @@ -3552,7 +3552,13 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio)
set_sbi_flag(sbi, SBI_NEED_FSCK);
f2fs_warn(sbi, "%s: incorrect segment(%u) type, run fsck to fix.",
__func__, segno);
return -EFSCORRUPTED;
err = -EFSCORRUPTED;
goto drop_bio;
}

if (is_sbi_flag_set(sbi, SBI_NEED_FSCK) || f2fs_cp_error(sbi)) {
err = -EIO;
goto drop_bio;
}

stat_inc_inplace_blocks(fio->sbi);
Expand All @@ -3566,6 +3572,15 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio)
f2fs_update_iostat(fio->sbi, fio->io_type, F2FS_BLKSIZE);
}

return err;
drop_bio:
if (fio->bio) {
struct bio *bio = *(fio->bio);

bio->bi_status = BLK_STS_IOERR;
bio_endio(bio);
fio->bio = NULL;
}
return err;
}

Expand Down

0 comments on commit 9557727

Please sign in to comment.