Skip to content

Commit

Permalink
platform/x86: intel_pmc_core: fix memleak on registration failure
Browse files Browse the repository at this point in the history
commit 26a8b09 upstream.

In case device registration fails during module initialisation, the
platform device structure needs to be freed using platform_device_put()
to properly free all resources (e.g. the device name).

Fixes: 938835a ("platform/x86: intel_pmc_core: do not create a static struct device")
Cc: stable@vger.kernel.org      # 5.9
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20211222105023.6205-1-johan@kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
jhovold authored and gregkh committed Dec 29, 2021
1 parent a42c41b commit 9ca1324
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/platform/x86/intel/pmc/pltdrv.c
Expand Up @@ -65,7 +65,7 @@ static int __init pmc_core_platform_init(void)

retval = platform_device_register(pmc_core_device);
if (retval)
kfree(pmc_core_device);
platform_device_put(pmc_core_device);

return retval;
}
Expand Down

0 comments on commit 9ca1324

Please sign in to comment.