Skip to content

Commit

Permalink
phonet: refcount leak in pep_sock_accep
Browse files Browse the repository at this point in the history
commit bcd0f93 upstream.

sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not
invoked in subsequent failure branches(pep_accept_conn() != 0).

Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20211209082839.33985-1-hbh25y@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Aayush Agarwal <aayush.a.agarwal@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
HBh25Y authored and gregkh committed Jan 11, 2022
1 parent d57da51 commit 9ca97a6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/phonet/pep.c
Expand Up @@ -868,6 +868,7 @@ static struct sock *pep_sock_accept(struct sock *sk, int flags, int *errp,

err = pep_accept_conn(newsk, skb);
if (err) {
__sock_put(sk);
sock_put(newsk);
newsk = NULL;
goto drop;
Expand Down

0 comments on commit 9ca97a6

Please sign in to comment.