Skip to content

Commit

Permalink
media: dvb: Add check on sp8870_readreg return
Browse files Browse the repository at this point in the history
[ Upstream commit c6d822c ]

The function sp8870_readreg returns a negative value when i2c_transfer
fails so properly check for this and return the error if it happens.

Cc: Sean Young <sean@mess.org>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Alaa Emad <alaaemadhossney.ae@gmail.com>
Link: https://lore.kernel.org/r/20210503115736.2104747-60-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
EngAlaaEmad authored and gregkh committed Jun 3, 2021
1 parent 7dae0ca commit 9fd73df
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/media/dvb-frontends/sp8870.c
Expand Up @@ -280,7 +280,9 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
sp8870_writereg(state, 0xc05, reg0xc05);

// read status reg in order to clear pending irqs
sp8870_readreg(state, 0x200);
err = sp8870_readreg(state, 0x200);
if (err < 0)
return err;

// system controller start
sp8870_microcontroller_start(state);
Expand Down

0 comments on commit 9fd73df

Please sign in to comment.