Skip to content

Commit

Permalink
samples/bpf: Fix the error return code of xdp_redirect's main()
Browse files Browse the repository at this point in the history
[ Upstream commit 7c6090e ]

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

If bpf_map_update_elem() failed, main() should return a negative error.

Fixes: 832622e ("xdp: sample program for new bpf_redirect helper")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20210616042534.315097-1-wanghai38@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Wang Hai authored and gregkh committed Jul 14, 2021
1 parent 9abfeb4 commit a00c9fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion samples/bpf/xdp_redirect_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -213,5 +213,5 @@ int main(int argc, char **argv)
poll_stats(2, ifindex_out);

out:
return 0;
return ret;
}

0 comments on commit a00c9fa

Please sign in to comment.