Skip to content

Commit

Permalink
um: fix error return code in slip_open()
Browse files Browse the repository at this point in the history
[ Upstream commit b77e81f ]

Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Fixes: a3c77c6 ("[PATCH] uml: slirp and slip driver cleanups and fixes")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Acked-By: anton.ivanov@cambridgegreys.com
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Zhen Lei authored and gregkh committed Jul 20, 2021
1 parent b71f114 commit a04880c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion arch/um/drivers/slip_user.c
Expand Up @@ -145,7 +145,8 @@ static int slip_open(void *data)
}
sfd = err;

if (set_up_tty(sfd))
err = set_up_tty(sfd);
if (err)
goto out_close2;

pri->slave = sfd;
Expand Down

0 comments on commit a04880c

Please sign in to comment.