Skip to content

Commit

Permalink
dmaengine: mv_xor_v2: Fix a resource leak in mv_xor_v2_remove()
Browse files Browse the repository at this point in the history
[ Upstream commit 081195d ]

A clk_prepare_enable() call in the probe is not balanced by a corresponding
clk_disable_unprepare() in the remove function.

Add the missing call.

Fixes: 3cd2c31 ("dmaengine: mv_xor_v2: Fix clock resource by adding a register clock")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/e9e3837a680c9bd2438e4db2b83270c6c052d005.1666640987.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
tititiou36 authored and gregkh committed Nov 16, 2022
1 parent e893b7d commit a1cb72e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/dma/mv_xor_v2.c
Expand Up @@ -893,6 +893,7 @@ static int mv_xor_v2_remove(struct platform_device *pdev)
tasklet_kill(&xor_dev->irq_tasklet);

clk_disable_unprepare(xor_dev->clk);
clk_disable_unprepare(xor_dev->reg_clk);

return 0;
}
Expand Down

0 comments on commit a1cb72e

Please sign in to comment.