Skip to content

Commit

Permalink
pwm: stm32-lp: Don't modify HW state in .remove() callback
Browse files Browse the repository at this point in the history
[ Upstream commit d44084c ]

A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
ukleinek authored and gregkh committed Sep 26, 2021
1 parent a6a2b36 commit a2551d0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/pwm/pwm-stm32-lp.c
Expand Up @@ -225,8 +225,6 @@ static int stm32_pwm_lp_remove(struct platform_device *pdev)
{
struct stm32_pwm_lp *priv = platform_get_drvdata(pdev);

pwm_disable(&priv->chip.pwms[0]);

return pwmchip_remove(&priv->chip);
}

Expand Down

0 comments on commit a2551d0

Please sign in to comment.