Skip to content

Commit

Permalink
media: camss: missing error code in msm_video_register()
Browse files Browse the repository at this point in the history
[ Upstream commit 9c67ed2 ]

This error path returns success but it should return -EINVAL.

Fixes: cba3819 ("media: camss: Format configuration per hardware version")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Dan Carpenter authored and gregkh committed Mar 4, 2021
1 parent 2b5d3ee commit a255af7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/media/platform/qcom/camss/camss-video.c
Expand Up @@ -961,6 +961,7 @@ int msm_video_register(struct camss_video *video, struct v4l2_device *v4l2_dev,
video->nformats = ARRAY_SIZE(formats_rdi_8x96);
}
} else {
ret = -EINVAL;
goto error_video_register;
}

Expand Down

0 comments on commit a255af7

Please sign in to comment.