Skip to content

Commit

Permalink
arch_topology: Remove early cacheinfo error message if -ENOENT
Browse files Browse the repository at this point in the history
commit 3522340 upstream.

fetch_cache_info() tries to get the number of cache leaves/levels
for each CPU in order to pre-allocate memory for cacheinfo struct.
Allocating this memory later triggers a:
  'BUG: sleeping function called from invalid context'
in PREEMPT_RT kernels.

If there is no cache related information available in DT or ACPI,
fetch_cache_info() fails and an error message is printed:
  'Early cacheinfo failed, ret = ...'

Not having cache information should be a valid configuration.
Remove the error message if fetch_cache_info() fails with -ENOENT.

Suggested-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/all/20230404-hatred-swimmer-6fecdf33b57a@spud/
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230414081453.244787-4-pierre.gondois@arm.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
pierregondois authored and gregkh committed May 11, 2023
1 parent 8f8cc81 commit a2a8706
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/base/arch_topology.c
Original file line number Diff line number Diff line change
Expand Up @@ -843,10 +843,11 @@ void __init init_cpu_topology(void)

for_each_possible_cpu(cpu) {
ret = fetch_cache_info(cpu);
if (ret) {
if (!ret)
continue;
else if (ret != -ENOENT)
pr_err("Early cacheinfo failed, ret = %d\n", ret);
break;
}
return;
}
}

Expand Down

0 comments on commit a2a8706

Please sign in to comment.