Skip to content

Commit

Permalink
powerpc/32s: Fix cleanup_cpu_mmu_context() compile bug
Browse files Browse the repository at this point in the history
[ Upstream commit c1bea0a ]

Currently pmac32_defconfig with SMP=y doesn't build:

  arch/powerpc/platforms/powermac/smp.c:
  error: implicit declaration of function 'cleanup_cpu_mmu_context'

It would be nice for consistency if all platforms clear mm_cpumask and
flush TLBs on unplug, but the TLB invalidation bug described in commit
01b0f0e ("powerpc/64s: Trim offlined CPUs from mm_cpumasks") only
applies to 64s and for now we only have the TLB flush code for that
platform.

So just add an empty version for 32-bit Book3S.

Fixes: 01b0f0e ("powerpc/64s: Trim offlined CPUs from mm_cpumasks")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
[mpe: Change log based on comments from Nick]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
mpe authored and gregkh committed Dec 30, 2020
1 parent 0572a4a commit a3c1680
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions arch/powerpc/include/asm/book3s/32/mmu-hash.h
Expand Up @@ -94,6 +94,7 @@ typedef struct {
} mm_context_t;

void update_bats(void);
static inline void cleanup_cpu_mmu_context(void) { };

/* patch sites */
extern s32 patch__hash_page_A0, patch__hash_page_A1, patch__hash_page_A2;
Expand Down

0 comments on commit a3c1680

Please sign in to comment.