-
Notifications
You must be signed in to change notification settings - Fork 102
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
selftests/rseq: Fix: work-around asm goto compiler bugs
commit b53823f upstream. gcc and clang each have their own compiler bugs with respect to asm goto. Implement a work-around for compiler versions known to have those bugs. gcc prior to 4.8.2 miscompiles asm goto. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58670 gcc prior to 8.1.0 miscompiles asm goto at O1. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908 clang prior to version 13.0.1 miscompiles asm goto at O2. llvm/llvm-project#52735 Work around these issues by adding a volatile inline asm with memory clobber in the fallthrough after the asm goto and at each label target. Emit this for all compilers in case other similar issues are found in the future. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20220124171253.22072-14-mathieu.desnoyers@efficios.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
- Loading branch information
Showing
7 changed files
with
245 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/* SPDX-License-Identifier: LGPL-2.1-only OR MIT */ | ||
/* | ||
* rseq/compiler.h | ||
* | ||
* Work-around asm goto compiler bugs. | ||
* | ||
* (C) Copyright 2021 - Mathieu Desnoyers <mathieu.desnoyers@efficios.com> | ||
*/ | ||
|
||
#ifndef RSEQ_COMPILER_H | ||
#define RSEQ_COMPILER_H | ||
|
||
/* | ||
* gcc prior to 4.8.2 miscompiles asm goto. | ||
* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58670 | ||
* | ||
* gcc prior to 8.1.0 miscompiles asm goto at O1. | ||
* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908 | ||
* | ||
* clang prior to version 13.0.1 miscompiles asm goto at O2. | ||
* https://github.com/llvm/llvm-project/issues/52735 | ||
* | ||
* Work around these issues by adding a volatile inline asm with | ||
* memory clobber in the fallthrough after the asm goto and at each | ||
* label target. Emit this for all compilers in case other similar | ||
* issues are found in the future. | ||
*/ | ||
#define rseq_after_asm_goto() asm volatile ("" : : : "memory") | ||
|
||
#endif /* RSEQ_COMPILER_H_ */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.