Skip to content

Commit

Permalink
khugepage: replace try_to_release_page() with filemap_release_folio()
Browse files Browse the repository at this point in the history
[ Upstream commit 64ab319 ]

Replace some calls with their folio equivalents.  This change removes 4
calls to compound_head() and is in preparation for the removal of the
try_to_release_page() wrapper.

Link: https://lkml.kernel.org/r/20221118073055.55694-3-vishal.moola@gmail.com
Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Naoya Horiguchi <naoya.horiguchi@nec.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Stable-dep-of: 1898efc ("block: update the stable_writes flag in bdev_add")
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
VMoola authored and gregkh committed Jan 10, 2024
1 parent 4c78612 commit a6f440f
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions mm/khugepaged.c
Original file line number Diff line number Diff line change
Expand Up @@ -1818,6 +1818,7 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr,
xas_set(&xas, start);
for (index = start; index < end; index++) {
struct page *page = xas_next(&xas);
struct folio *folio;

VM_BUG_ON(index != xas.xa_index);
if (is_shmem) {
Expand All @@ -1844,8 +1845,6 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr,
}

if (xa_is_value(page) || !PageUptodate(page)) {
struct folio *folio;

xas_unlock_irq(&xas);
/* swap in or instantiate fallocated page */
if (shmem_get_folio(mapping->host, index,
Expand Down Expand Up @@ -1933,13 +1932,15 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr,
goto out_unlock;
}

if (page_mapping(page) != mapping) {
folio = page_folio(page);

if (folio_mapping(folio) != mapping) {
result = SCAN_TRUNCATED;
goto out_unlock;
}

if (!is_shmem && (PageDirty(page) ||
PageWriteback(page))) {
if (!is_shmem && (folio_test_dirty(folio) ||
folio_test_writeback(folio))) {
/*
* khugepaged only works on read-only fd, so this
* page is dirty because it hasn't been flushed
Expand All @@ -1949,20 +1950,20 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr,
goto out_unlock;
}

if (isolate_lru_page(page)) {
if (folio_isolate_lru(folio)) {
result = SCAN_DEL_PAGE_LRU;
goto out_unlock;
}

if (page_has_private(page) &&
!try_to_release_page(page, GFP_KERNEL)) {
if (folio_has_private(folio) &&
!filemap_release_folio(folio, GFP_KERNEL)) {
result = SCAN_PAGE_HAS_PRIVATE;
putback_lru_page(page);
folio_putback_lru(folio);
goto out_unlock;
}

if (page_mapped(page))
try_to_unmap(page_folio(page),
if (folio_mapped(folio))
try_to_unmap(folio,
TTU_IGNORE_MLOCK | TTU_BATCH_FLUSH);

xas_lock_irq(&xas);
Expand Down

0 comments on commit a6f440f

Please sign in to comment.