Skip to content

Commit

Permalink
Revert "workqueue: Don't call cpumask_test_cpu() with -1 CPU in wq_up…
Browse files Browse the repository at this point in the history
…date_node_max_active()"

This reverts commit 7df62b8 which is
commit 15930da upstream.

The workqueue patches backported to 6.6.y caused some reported
regressions, so revert them for now.

Reported-by: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Tejun Heo <tj@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>
Cc: Audra Mitchell <audra@redhat.com>
Link: https://lore.kernel.org/all/ce4c2f67-c298-48a0-87a3-f933d646c73b@leemhuis.info/
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
gregkh committed Apr 4, 2024
1 parent 7bff182 commit a75ac26
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/workqueue.c
Expand Up @@ -1500,7 +1500,7 @@ static void wq_update_node_max_active(struct workqueue_struct *wq, int off_cpu)

lockdep_assert_held(&wq->mutex);

if (off_cpu >= 0 && !cpumask_test_cpu(off_cpu, effective))
if (!cpumask_test_cpu(off_cpu, effective))
off_cpu = -1;

total_cpus = cpumask_weight_and(effective, cpu_online_mask);
Expand Down

0 comments on commit a75ac26

Please sign in to comment.