Skip to content

Commit

Permalink
soc: mediatek: fix missing clk_disable_unprepare() on err in svs_resu…
Browse files Browse the repository at this point in the history
…me()

Fix the missing clk_disable_unprepare() before return
from svs_resume() in the error handling case.

Signed-off-by: Peng Wu <wupeng58@huawei.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Link: https://lore.kernel.org/r/20220623070240.63382-1-wupeng58@huawei.com
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
  • Loading branch information
Peng Wu authored and mbgg committed Jun 23, 2022
1 parent 44e36d7 commit a825d72
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/soc/mediatek/mtk-svs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1526,16 +1526,20 @@ static int svs_resume(struct device *dev)
ret = reset_control_deassert(svsp->rst);
if (ret) {
dev_err(svsp->dev, "cannot deassert reset %d\n", ret);
return ret;
goto out_of_resume;
}

ret = svs_init02(svsp);
if (ret)
return ret;
goto out_of_resume;

svs_mon_mode(svsp);

return 0;

out_of_resume:
clk_disable_unprepare(svsp->main_clk);
return ret;
}

static int svs_bank_resource_setup(struct svs_platform *svsp)
Expand Down

0 comments on commit a825d72

Please sign in to comment.