Skip to content

Commit

Permalink
media: ati_remote: sanity check for both endpoints
Browse files Browse the repository at this point in the history
If you do sanity checks, you should do them for both endpoints.
Hence introduce checking for endpoint type for the output
endpoint, too.

Reported-by: syzbot+998261c2ae5932458f6c@syzkaller.appspotmail.com
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  • Loading branch information
oneukum authored and mchehab committed Sep 27, 2020
1 parent ce5d72b commit a8be800
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/media/rc/ati_remote.c
Original file line number Diff line number Diff line change
Expand Up @@ -835,6 +835,10 @@ static int ati_remote_probe(struct usb_interface *interface,
err("%s: endpoint_in message size==0? \n", __func__);
return -ENODEV;
}
if (!usb_endpoint_is_int_out(endpoint_out)) {
err("%s: Unexpected endpoint_out\n", __func__);
return -ENODEV;
}

ati_remote = kzalloc(sizeof (struct ati_remote), GFP_KERNEL);
rc_dev = rc_allocate_device(RC_DRIVER_SCANCODE);
Expand Down

0 comments on commit a8be800

Please sign in to comment.