Skip to content

Commit

Permalink
selftests/powerpc: Fix "no_handler" EBB selftest
Browse files Browse the repository at this point in the history
[ Upstream commit 45677c9 ]

The "no_handler_test" in ebb selftests attempts to read the PMU
registers twice via helper function "dump_ebb_state". First dump is
just before closing of event and the second invocation is done after
closing of the event. The original intention of second
dump_ebb_state was to dump the state of registers at the end of
the test when the counters are frozen. But this will be achieved
with the first call itself since sample period is set to low value
and PMU will be frozen by then. Hence patch removes the
dump which was done before closing of the event.

Reported-by: Shirisha Ganta <shirisha.ganta1@ibm.com>
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com <mailto:rnsastry@linux.ibm.com>>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1621950703-1532-2-git-send-email-atrajeev@linux.vnet.ibm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
athira-rajeev authored and gregkh committed Jul 20, 2021
1 parent df6b21c commit ac2ee94
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions tools/testing/selftests/powerpc/pmu/ebb/no_handler_test.c
Expand Up @@ -50,8 +50,6 @@ static int no_handler_test(void)

event_close(&event);

dump_ebb_state();

/* The real test is that we never took an EBB at 0x0 */

return 0;
Expand Down

0 comments on commit ac2ee94

Please sign in to comment.