Skip to content

Commit

Permalink
regulator: s5m8767: Drop regulators OF node reference
Browse files Browse the repository at this point in the history
[ Upstream commit a5872bd ]

The device node reference obtained with of_get_child_by_name() should be
dropped on error paths.

Fixes: 26aec00 ("regulator: add device tree support for s5m8767")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20210121155914.48034-1-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
krzk authored and gregkh committed Mar 4, 2021
1 parent ac5ab9c commit b1ff96e
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/regulator/s5m8767.c
Expand Up @@ -544,14 +544,18 @@ static int s5m8767_pmic_dt_parse_pdata(struct platform_device *pdev,
rdata = devm_kcalloc(&pdev->dev,
pdata->num_regulators, sizeof(*rdata),
GFP_KERNEL);
if (!rdata)
if (!rdata) {
of_node_put(regulators_np);
return -ENOMEM;
}

rmode = devm_kcalloc(&pdev->dev,
pdata->num_regulators, sizeof(*rmode),
GFP_KERNEL);
if (!rmode)
if (!rmode) {
of_node_put(regulators_np);
return -ENOMEM;
}

pdata->regulators = rdata;
pdata->opmode = rmode;
Expand Down

0 comments on commit b1ff96e

Please sign in to comment.