Skip to content

Commit

Permalink
ASoC: rt5670: Remove unbalanced pm_runtime_put()
Browse files Browse the repository at this point in the history
[ Upstream commit 6c900dc ]

For some reason rt5670_i2c_probe() does a pm_runtime_put() at the end
of a successful probe. But it has never done a pm_runtime_get() leading
to the following error being logged into dmesg:

 rt5670 i2c-10EC5640:00: Runtime PM usage count underflow!

Fix this by removing the unnecessary pm_runtime_put().

Fixes: 64e89e5 ("ASoC: rt5670: Add runtime PM support")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20221213123319.11285-1-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
jwrdegoede authored and gregkh committed Dec 31, 2022
1 parent 59f797a commit b253e07
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions sound/soc/codecs/rt5670.c
Expand Up @@ -3313,8 +3313,6 @@ static int rt5670_i2c_probe(struct i2c_client *i2c,
if (ret < 0)
goto err;

pm_runtime_put(&i2c->dev);

return 0;
err:
pm_runtime_disable(&i2c->dev);
Expand Down

0 comments on commit b253e07

Please sign in to comment.