Skip to content

Commit

Permalink
arm64: dts: apple: t8103: Disable unused PCIe ports
Browse files Browse the repository at this point in the history
[ Upstream commit a0189fd ]

The PCIe ports are unused (without devices) so disable them instead of
removing them.

Fixes: 7c77ab9 ("arm64: dts: apple: Add missing M1 (t8103) devices")
Signed-off-by: Janne Grunau <j@jannau.net>
Reviewed-by: Sven Peter <sven@svenpeter.dev>
Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
jannau authored and gregkh committed May 11, 2023
1 parent 2af9741 commit b28bbfb
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 38 deletions.
10 changes: 10 additions & 0 deletions arch/arm64/boot/dts/apple/t8103-j274.dts
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,27 @@

&port01 {
bus-range = <2 2>;
status = "okay";
};

&port02 {
bus-range = <3 3>;
status = "okay";
ethernet0: ethernet@0,0 {
reg = <0x30000 0x0 0x0 0x0 0x0>;
/* To be filled by the loader */
local-mac-address = [00 10 18 00 00 00];
};
};

&pcie0_dart_1 {
status = "okay";
};

&pcie0_dart_2 {
status = "okay";
};

&i2c2 {
status = "okay";
};
15 changes: 0 additions & 15 deletions arch/arm64/boot/dts/apple/t8103-j293.dts
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,6 @@
brcm,board-type = "apple,honshu";
};

/*
* Remove unused PCIe ports and disable the associated DARTs.
*/

&pcie0_dart_1 {
status = "disabled";
};

&pcie0_dart_2 {
status = "disabled";
};

/delete-node/ &port01;
/delete-node/ &port02;

&i2c2 {
status = "okay";
};
Expand Down
15 changes: 0 additions & 15 deletions arch/arm64/boot/dts/apple/t8103-j313.dts
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,3 @@
&wifi0 {
brcm,board-type = "apple,shikoku";
};

/*
* Remove unused PCIe ports and disable the associated DARTs.
*/

&pcie0_dart_1 {
status = "disabled";
};

&pcie0_dart_2 {
status = "disabled";
};

/delete-node/ &port01;
/delete-node/ &port02;
10 changes: 10 additions & 0 deletions arch/arm64/boot/dts/apple/t8103-j456.dts
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,23 @@

&port01 {
bus-range = <2 2>;
status = "okay";
};

&port02 {
bus-range = <3 3>;
status = "okay";
ethernet0: ethernet@0,0 {
reg = <0x30000 0x0 0x0 0x0 0x0>;
/* To be filled by the loader */
local-mac-address = [00 10 18 00 00 00];
};
};

&pcie0_dart_1 {
status = "okay";
};

&pcie0_dart_2 {
status = "okay";
};
11 changes: 3 additions & 8 deletions arch/arm64/boot/dts/apple/t8103-j457.dts
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,14 @@

&port02 {
bus-range = <3 3>;
status = "okay";
ethernet0: ethernet@0,0 {
reg = <0x30000 0x0 0x0 0x0 0x0>;
/* To be filled by the loader */
local-mac-address = [00 10 18 00 00 00];
};
};

/*
* Remove unused PCIe port and disable the associated DART.
*/

&pcie0_dart_1 {
status = "disabled";
&pcie0_dart_2 {
status = "okay";
};

/delete-node/ &port01;
4 changes: 4 additions & 0 deletions arch/arm64/boot/dts/apple/t8103.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,7 @@
interrupt-parent = <&aic>;
interrupts = <AIC_IRQ 699 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&ps_apcie_gp>;
status = "disabled";
};

pcie0_dart_2: iommu@683008000 {
Expand All @@ -733,6 +734,7 @@
interrupt-parent = <&aic>;
interrupts = <AIC_IRQ 702 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&ps_apcie_gp>;
status = "disabled";
};

pcie0: pcie@690000000 {
Expand Down Expand Up @@ -807,6 +809,7 @@
<0 0 0 2 &port01 0 0 0 1>,
<0 0 0 3 &port01 0 0 0 2>,
<0 0 0 4 &port01 0 0 0 3>;
status = "disabled";
};

port02: pci@2,0 {
Expand All @@ -826,6 +829,7 @@
<0 0 0 2 &port02 0 0 0 1>,
<0 0 0 3 &port02 0 0 0 2>,
<0 0 0 4 &port02 0 0 0 3>;
status = "disabled";
};
};
};
Expand Down

0 comments on commit b28bbfb

Please sign in to comment.