Skip to content

Commit

Permalink
erofs: apply proper VMA alignment for memory mapped files on THP
Browse files Browse the repository at this point in the history
[ Upstream commit 4127cae ]

There are mainly two reasons that thp_get_unmapped_area() should be
used for EROFS as other filesystems:

 - It's needed to enable PMD mappings as a FSDAX filesystem, see
   commit 74d2fad ("thp, dax: add thp_get_unmapped_area for pmd
   mappings");

 - It's useful together with large folios and
   CONFIG_READ_ONLY_THP_FOR_FS which enable THPs for mmapped files
   (e.g. shared libraries) even without FSDAX.  See commit 1854bc6
   ("mm/readahead: Align file mappings for non-DAX").

Fixes: 06252e9 ("erofs: dax support for non-tailpacking regular file")
Fixes: ce529cc ("erofs: enable large folios for iomap mode")
Fixes: e6687b8 ("erofs: enable large folios for fscache mode")
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20240306053138.2240206-1-hsiangkao@linux.alibaba.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
hsiangkao authored and Sasha Levin committed Mar 15, 2024
1 parent 014a807 commit b3b8752
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/erofs/data.c
Original file line number Diff line number Diff line change
Expand Up @@ -448,5 +448,6 @@ const struct file_operations erofs_file_fops = {
.llseek = generic_file_llseek,
.read_iter = erofs_file_read_iter,
.mmap = erofs_file_mmap,
.get_unmapped_area = thp_get_unmapped_area,
.splice_read = filemap_splice_read,
};

0 comments on commit b3b8752

Please sign in to comment.