Skip to content

Commit

Permalink
ASoC: SOF: sof-audio: unprepare when swidget->use_count > 0
Browse files Browse the repository at this point in the history
commit 7d2a67e upstream.

We should unprepare the widget if its use_count = 1.

Fixes: 9862dcf ("ASoC: SOF: don't unprepare widget used other pipelines")
Cc: <stable@vger.kernel.org> # 6.1
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230118101255.29139-2-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
bardliao authored and gregkh committed Feb 9, 2023
1 parent 60a1ffe commit b6552a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/soc/sof/sof-audio.c
Expand Up @@ -272,7 +272,7 @@ sof_unprepare_widgets_in_path(struct snd_sof_dev *sdev, struct snd_soc_dapm_widg
struct snd_soc_dapm_path *p;

/* return if the widget is in use or if it is already unprepared */
if (!swidget->prepared || swidget->use_count > 1)
if (!swidget->prepared || swidget->use_count > 0)
return;

if (widget_ops[widget->id].ipc_unprepare)
Expand Down

0 comments on commit b6552a7

Please sign in to comment.