Skip to content

Commit

Permalink
selftests: mptcp: allow more slack for slow test-case
Browse files Browse the repository at this point in the history
commit a635a8c upstream.

A test-case is frequently failing on some extremely slow VMs.
The mptcp transfer completes before the script is able to do
all the required PM manipulation.

Address the issue in the simplest possible way, making the
transfer even more slow.

Additionally dump more info in case of failures, to help debugging
similar problems in the future and init dump_stats var.

Fixes: e274f71 ("selftests: mptcp: add subflow limits test-cases")
Cc: stable@vger.kernel.org
Closes: multipath-tcp/mptcp_net-next#323
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Paolo Abeni authored and gregkh committed Feb 14, 2023
1 parent ba36772 commit b7692fb
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions tools/testing/selftests/net/mptcp/mptcp_join.sh
Expand Up @@ -1688,6 +1688,7 @@ chk_subflow_nr()
local subflow_nr=$3
local cnt1
local cnt2
local dump_stats

if [ -n "${need_title}" ]; then
printf "%03u %-36s %s" "${TEST_COUNT}" "${TEST_NAME}" "${msg}"
Expand All @@ -1705,7 +1706,12 @@ chk_subflow_nr()
echo "[ ok ]"
fi

[ "${dump_stats}" = 1 ] && ( ss -N $ns1 -tOni ; ss -N $ns1 -tOni | grep token; ip -n $ns1 mptcp endpoint )
if [ "${dump_stats}" = 1 ]; then
ss -N $ns1 -tOni
ss -N $ns1 -tOni | grep token
ip -n $ns1 mptcp endpoint
dump_stats
fi
}

chk_link_usage()
Expand Down Expand Up @@ -3005,7 +3011,7 @@ endpoint_tests()
pm_nl_set_limits $ns1 1 1
pm_nl_set_limits $ns2 1 1
pm_nl_add_endpoint $ns2 10.0.2.2 id 2 dev ns2eth2 flags subflow
run_tests $ns1 $ns2 10.0.1.1 4 0 0 slow &
run_tests $ns1 $ns2 10.0.1.1 4 0 0 speed_20 &

wait_mpj $ns2
pm_nl_del_endpoint $ns2 2 10.0.2.2
Expand Down

0 comments on commit b7692fb

Please sign in to comment.