Skip to content

Commit

Permalink
arm64: dts: qcom: msm8916: Fix MDP/DSI interrupts
Browse files Browse the repository at this point in the history
[ Upstream commit 027cca9 ]

The mdss node sets #interrupt-cells = <1>, so its interrupts
should be referenced using a single cell (in this case: only the
interrupt number).

However, right now the mdp/dsi node both have two interrupt cells
set, e.g. interrupts = <4 0>. The 0 is probably meant to say
IRQ_TYPE_NONE (= 0), but with #interrupt-cells = <1> this is
actually interpreted as a second interrupt line.

Remove the IRQ flags from both interrupts to fix this.

Fixes: 305410f ("arm64: dts: msm8916: Add display support")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20200915071221.72895-5-stephan@gerhold.net
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
stephan-gh authored and gregkh committed Oct 29, 2020
1 parent 1e61c8f commit b78cdf1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/qcom/msm8916.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,7 @@
reg-names = "mdp_phys";

interrupt-parent = <&mdss>;
interrupts = <0 0>;
interrupts = <0>;

clocks = <&gcc GCC_MDSS_AHB_CLK>,
<&gcc GCC_MDSS_AXI_CLK>,
Expand Down Expand Up @@ -966,7 +966,7 @@
reg-names = "dsi_ctrl";

interrupt-parent = <&mdss>;
interrupts = <4 0>;
interrupts = <4>;

assigned-clocks = <&gcc BYTE0_CLK_SRC>,
<&gcc PCLK0_CLK_SRC>;
Expand Down

0 comments on commit b78cdf1

Please sign in to comment.