Skip to content

Commit

Permalink
can: pch_can: do not report txerr and rxerr during bus-off
Browse files Browse the repository at this point in the history
[ Upstream commit 3a5c7e4 ]

During bus off, the error count is greater than 255 and can not fit in
a u8.

Fixes: 0c78ab7 ("pch_can: Add setting TEC/REC statistics processing")
Link: https://lore.kernel.org/all/20220719143550.3681-2-mailhol.vincent@wanadoo.fr
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
vincent-mailhol authored and gregkh committed Aug 17, 2022
1 parent cbfcc7c commit ba0110c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/can/pch_can.c
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,9 @@ static void pch_can_error(struct net_device *ndev, u32 status)
cf->can_id |= CAN_ERR_BUSOFF;
priv->can.can_stats.bus_off++;
can_bus_off(ndev);
} else {
cf->data[6] = errc & PCH_TEC;
cf->data[7] = (errc & PCH_REC) >> 8;
}

errc = ioread32(&priv->regs->errc);
Expand Down Expand Up @@ -556,9 +559,6 @@ static void pch_can_error(struct net_device *ndev, u32 status)
break;
}

cf->data[6] = errc & PCH_TEC;
cf->data[7] = (errc & PCH_REC) >> 8;

priv->can.state = state;
netif_receive_skb(skb);

Expand Down

0 comments on commit ba0110c

Please sign in to comment.