Skip to content

Commit

Permalink
drm/bridge: anx7625: Use common macros for DP power sequencing commands
Browse files Browse the repository at this point in the history
[ Upstream commit 2ba776f ]

The DRM DP code has macros for the DP power sequencing commands. Use
them in the anx7625 driver instead of raw numbers.

Fixes: 548b512 ("drm/bridge: anx7625: send DPCD command to downstream")
Fixes: 27f2635 ("drm/bridge: anx7625: Set downstream sink into normal status")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230710090929.1873646-1-wenst@chromium.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
wens authored and gregkh committed Sep 13, 2023
1 parent d309b17 commit ba1ca2c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/gpu/drm/bridge/analogix/anx7625.c
Expand Up @@ -933,8 +933,8 @@ static void anx7625_dp_start(struct anx7625_data *ctx)

dev_dbg(dev, "set downstream sink into normal\n");
/* Downstream sink enter into normal mode */
data = 1;
ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data);
data = DP_SET_POWER_D0;
ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, DP_SET_POWER, 1, &data);
if (ret < 0)
dev_err(dev, "IO error : set sink into normal mode fail\n");

Expand Down Expand Up @@ -973,8 +973,8 @@ static void anx7625_dp_stop(struct anx7625_data *ctx)

dev_dbg(dev, "notify downstream enter into standby\n");
/* Downstream monitor enter into standby mode */
data = 2;
ret |= anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data);
data = DP_SET_POWER_D3;
ret |= anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, DP_SET_POWER, 1, &data);
if (ret < 0)
DRM_DEV_ERROR(dev, "IO error : mute video fail\n");

Expand Down

0 comments on commit ba1ca2c

Please sign in to comment.