Skip to content

Commit

Permalink
3c589_cs: Fix an error handling path in tc589_probe()
Browse files Browse the repository at this point in the history
commit 640bf95 upstream.

Should tc589_config() fail, some resources need to be released as already
done in the remove function.

Fixes: 15b99ac ("[PATCH] pcmcia: add return value to _config() functions")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/d8593ae867b24c79063646e36f9b18b0790107cb.1684575975.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
tititiou36 authored and gregkh committed May 30, 2023
1 parent d33be18 commit ba3441b
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion drivers/net/ethernet/3com/3c589_cs.c
Expand Up @@ -195,6 +195,7 @@ static int tc589_probe(struct pcmcia_device *link)
{
struct el3_private *lp;
struct net_device *dev;
int ret;

dev_dbg(&link->dev, "3c589_attach()\n");

Expand All @@ -218,7 +219,15 @@ static int tc589_probe(struct pcmcia_device *link)

dev->ethtool_ops = &netdev_ethtool_ops;

return tc589_config(link);
ret = tc589_config(link);
if (ret)
goto err_free_netdev;

return 0;

err_free_netdev:
free_netdev(dev);
return ret;
}

static void tc589_detach(struct pcmcia_device *link)
Expand Down

0 comments on commit ba3441b

Please sign in to comment.