Skip to content

Commit

Permalink
video: fbdev: clcdfb: Fix refcount leak in clcdfb_of_vram_setup
Browse files Browse the repository at this point in the history
[ Upstream commit b23789a ]

of_parse_phandle() returns a node pointer with refcount incremented, we should
use of_node_put() on it when not need anymore.  Add missing of_node_put() to
avoid refcount leak.

Fixes: d10715b ("video: ARM CLCD: Add DT support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Yuuoniy authored and gregkh committed Jun 9, 2022
1 parent 3a205d5 commit bbb2a24
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/video/fbdev/amba-clcd.c
Expand Up @@ -758,12 +758,15 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb)
return -ENODEV;

fb->fb.screen_base = of_iomap(memory, 0);
if (!fb->fb.screen_base)
if (!fb->fb.screen_base) {
of_node_put(memory);
return -ENOMEM;
}

fb->fb.fix.smem_start = of_translate_address(memory,
of_get_address(memory, 0, &size, NULL));
fb->fb.fix.smem_len = size;
of_node_put(memory);

return 0;
}
Expand Down

0 comments on commit bbb2a24

Please sign in to comment.