Skip to content

Commit

Permalink
gpio: mpc8xxx: Fix an ignored error return from platform_get_irq()
Browse files Browse the repository at this point in the history
commit 9f51ce0 upstream.

The return from the call to platform_get_irq() is int, it can be
a negative error code, however this is being assigned to an unsigned
int variable 'irqn', so making 'irqn' an int.

Eliminate the following coccicheck warning:
./drivers/gpio/gpio-mpc8xxx.c:391:5-21: WARNING: Unsigned expression
compared with zero: mpc8xxx_gc -> irqn < 0

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 0b39536 ("gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Yang Li authored and gregkh committed Feb 8, 2022
1 parent 54e8d33 commit bc3d8a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpio/gpio-mpc8xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ struct mpc8xxx_gpio_chip {
unsigned offset, int value);

struct irq_domain *irq;
unsigned int irqn;
int irqn;
};

/*
Expand Down

0 comments on commit bc3d8a9

Please sign in to comment.