Skip to content

Commit

Permalink
ipv6: Continue processing multipath route even if gateway attribute i…
Browse files Browse the repository at this point in the history
…s invalid

[ Upstream commit e30a845 ]

ip6_route_multipath_del loop continues processing the multipath
attribute even if delete of a nexthop path fails. For consistency,
do the same if the gateway attribute is invalid.

Fixes: 1ff15a7 ("ipv6: Check attribute length for RTA_GATEWAY when deleting multipath route")
Signed-off-by: David Ahern <dsahern@kernel.org>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Link: https://lore.kernel.org/r/20220103171911.94739-1-dsahern@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
dsahern authored and gregkh committed Jan 11, 2022
1 parent 5aec746 commit c1de618
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions net/ipv6/route.c
Expand Up @@ -5459,8 +5459,10 @@ static int ip6_route_multipath_del(struct fib6_config *cfg,
if (nla) {
err = fib6_gw_from_attr(&r_cfg.fc_gateway, nla,
extack);
if (err)
return err;
if (err) {
last_err = err;
goto next_rtnh;
}

r_cfg.fc_flags |= RTF_GATEWAY;
}
Expand All @@ -5469,6 +5471,7 @@ static int ip6_route_multipath_del(struct fib6_config *cfg,
if (err)
last_err = err;

next_rtnh:
rtnh = rtnh_next(rtnh, &remaining);
}

Expand Down

0 comments on commit c1de618

Please sign in to comment.