Skip to content

Commit

Permalink
net: ethernet: adi: adin1110: use eth_broadcast_addr() to assign broa…
Browse files Browse the repository at this point in the history
…dcast address

[ Upstream commit 54024db ]

Use eth_broadcast_addr() to assign broadcast address instead
of memset().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Stable-dep-of: 32530db ("net:ethernet:adi:adin1110: Fix forwarding offload")
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Yang Yingliang authored and gregkh committed Sep 19, 2023
1 parent 61866f7 commit c281948
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/ethernet/adi/adin1110.c
Expand Up @@ -740,7 +740,7 @@ static int adin1110_broadcasts_filter(struct adin1110_port_priv *port_priv,
u32 port_rules = 0;
u8 mask[ETH_ALEN];

memset(mask, 0xFF, ETH_ALEN);
eth_broadcast_addr(mask);

if (accept_broadcast && port_priv->state == BR_STATE_FORWARDING)
port_rules = adin1110_port_rules(port_priv, true, true);
Expand All @@ -761,7 +761,7 @@ static int adin1110_set_mac_address(struct net_device *netdev,
return -EADDRNOTAVAIL;

eth_hw_addr_set(netdev, dev_addr);
memset(mask, 0xFF, ETH_ALEN);
eth_broadcast_addr(mask);

mac_slot = (!port_priv->nr) ? ADIN_MAC_P1_ADDR_SLOT : ADIN_MAC_P2_ADDR_SLOT;
port_rules = adin1110_port_rules(port_priv, true, false);
Expand Down Expand Up @@ -1251,7 +1251,7 @@ static int adin1110_port_set_blocking_state(struct adin1110_port_priv *port_priv
goto out;

/* Allow only BPDUs to be passed to the CPU */
memset(mask, 0xFF, ETH_ALEN);
eth_broadcast_addr(mask);
port_rules = adin1110_port_rules(port_priv, true, false);
ret = adin1110_write_mac_address(port_priv, mac_slot, mac,
mask, port_rules);
Expand Down Expand Up @@ -1366,7 +1366,7 @@ static int adin1110_fdb_add(struct adin1110_port_priv *port_priv,

other_port = priv->ports[!port_priv->nr];
port_rules = adin1110_port_rules(port_priv, false, true);
memset(mask, 0xFF, ETH_ALEN);
eth_broadcast_addr(mask);

return adin1110_write_mac_address(other_port, mac_nr, (u8 *)fdb->addr,
mask, port_rules);
Expand Down

0 comments on commit c281948

Please sign in to comment.