Skip to content

Commit

Permalink
x86: Move gds_ucode_mitigated() declaration to header
Browse files Browse the repository at this point in the history
commit eb3515d upstream.

The declaration got placed in the .c file of the caller, but that
causes a warning for the definition:

arch/x86/kernel/cpu/bugs.c:682:6: error: no previous prototype for 'gds_ucode_mitigated' [-Werror=missing-prototypes]

Move it to a header where both sides can observe it instead.

Fixes: 81ac7e5 ("KVM: Add GDS_NO support to KVM")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Tested-by: Daniel Sneddon <daniel.sneddon@linux.intel.com>
Cc: stable@kernel.org
Link: https://lore.kernel.org/all/20230809130530.1913368-2-arnd%40kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
arndb authored and gregkh committed Aug 16, 2023
1 parent f0d3379 commit c4ea4f7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 2 additions & 0 deletions arch/x86/include/asm/processor.h
Expand Up @@ -732,4 +732,6 @@ bool arch_is_platform_page(u64 paddr);
#define arch_is_platform_page arch_is_platform_page
#endif

extern bool gds_ucode_mitigated(void);

#endif /* _ASM_X86_PROCESSOR_H */
2 changes: 0 additions & 2 deletions arch/x86/kvm/x86.c
Expand Up @@ -314,8 +314,6 @@ u64 __read_mostly host_xcr0;

static struct kmem_cache *x86_emulator_cache;

extern bool gds_ucode_mitigated(void);

/*
* When called, it means the previous get/set msr reached an invalid msr.
* Return true if we want to ignore/silent this failed msr access.
Expand Down

0 comments on commit c4ea4f7

Please sign in to comment.