Skip to content

Commit

Permalink
ARM: dts: sun7i: bananapi-m1-plus: Enable RGMII RX/TX delay on Ethern…
Browse files Browse the repository at this point in the history
…et PHY

[ Upstream commit f94f78b ]

The Ethernet PHY on the Bananapi M1+ has the RX and TX delays
enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins.

Fix the phy-mode description to correct reflect this so that the
implementation doesn't reconfigure the delays incorrectly. This
happened with commit bbc4d71 ("net: phy: realtek: fix rtl8211e
rx/tx delay config").

Fixes: 04c85ec ("ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Link: https://lore.kernel.org/r/20201024162515.30032-4-wens@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
wens authored and gregkh committed Nov 24, 2020
1 parent e99dc29 commit c6a9e1e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
phy-mode = "rgmii";
phy-mode = "rgmii-id";
phy-supply = <&reg_gmac_3v3>;
status = "okay";
};
Expand Down

0 comments on commit c6a9e1e

Please sign in to comment.