Skip to content

Commit

Permalink
i2c: rcar: fix PM ref counts in probe error paths
Browse files Browse the repository at this point in the history
[ Upstream commit 3fe2ec5 ]

We have to take care of ID_P_PM_BLOCKED when bailing out during probe.

Fixes: 7ee24eb ("i2c: rcar: disable PM in multi-master mode")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
morimoto authored and gregkh committed Jun 9, 2022
1 parent ebd4f37 commit c9542f5
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions drivers/i2c/busses/i2c-rcar.c
Original file line number Diff line number Diff line change
Expand Up @@ -999,8 +999,10 @@ static int rcar_i2c_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
pm_runtime_get_sync(dev);
ret = rcar_i2c_clock_calculate(priv);
if (ret < 0)
goto out_pm_put;
if (ret < 0) {
pm_runtime_put(dev);
goto out_pm_disable;
}

rcar_i2c_write(priv, ICSAR, 0); /* Gen2: must be 0 if not using slave */

Expand Down Expand Up @@ -1029,19 +1031,19 @@ static int rcar_i2c_probe(struct platform_device *pdev)

ret = platform_get_irq(pdev, 0);
if (ret < 0)
goto out_pm_disable;
goto out_pm_put;
priv->irq = ret;
ret = devm_request_irq(dev, priv->irq, irqhandler, irqflags, dev_name(dev), priv);
if (ret < 0) {
dev_err(dev, "cannot get irq %d\n", priv->irq);
goto out_pm_disable;
goto out_pm_put;
}

platform_set_drvdata(pdev, priv);

ret = i2c_add_numbered_adapter(adap);
if (ret < 0)
goto out_pm_disable;
goto out_pm_put;

if (priv->flags & ID_P_HOST_NOTIFY) {
priv->host_notify_client = i2c_new_slave_host_notify_device(adap);
Expand All @@ -1058,7 +1060,8 @@ static int rcar_i2c_probe(struct platform_device *pdev)
out_del_device:
i2c_del_adapter(&priv->adap);
out_pm_put:
pm_runtime_put(dev);
if (priv->flags & ID_P_PM_BLOCKED)
pm_runtime_put(dev);
out_pm_disable:
pm_runtime_disable(dev);
return ret;
Expand Down

0 comments on commit c9542f5

Please sign in to comment.