Skip to content

Commit

Permalink
x86/entry: Fix noinstr fail in __do_fast_syscall_32()
Browse files Browse the repository at this point in the history
[ Upstream commit 240001d ]

Fix:

  vmlinux.o: warning: objtool: __do_fast_syscall_32()+0xf5: call to trace_hardirqs_off() leaves .noinstr.text section

Fixes: 5d5675d ("x86/entry: Fix entry/exit mismatch on failed fast 32-bit syscalls")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210621120120.467898710@infradead.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Peter Zijlstra authored and Sasha Levin committed Jun 30, 2021
1 parent cf59354 commit cb83c99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/entry/common.c
Expand Up @@ -127,8 +127,8 @@ static noinstr bool __do_fast_syscall_32(struct pt_regs *regs)
/* User code screwed up. */
regs->ax = -EFAULT;

instrumentation_end();
local_irq_disable();
instrumentation_end();
irqentry_exit_to_user_mode(regs);
return false;
}
Expand Down

0 comments on commit cb83c99

Please sign in to comment.