Skip to content

Commit

Permalink
ASoC: tas2770: Insert post reset delay
Browse files Browse the repository at this point in the history
commit 307f314 upstream.

Per TAS2770 datasheet there must be a 1 ms delay from reset to first
command. So insert delays into the driver where appropriate.

Fixes: 1a476ab ("tas2770: add tas2770 smart PA kernel driver")
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20220204095301.5554-1-povik+lin@cutebit.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
povik authored and gregkh committed Feb 23, 2022
1 parent d69d98d commit ce38a92
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion sound/soc/codecs/tas2770.c
Expand Up @@ -38,10 +38,12 @@ static void tas2770_reset(struct tas2770_priv *tas2770)
gpiod_set_value_cansleep(tas2770->reset_gpio, 0);
msleep(20);
gpiod_set_value_cansleep(tas2770->reset_gpio, 1);
usleep_range(1000, 2000);
}

snd_soc_component_write(tas2770->component, TAS2770_SW_RST,
TAS2770_RST);
usleep_range(1000, 2000);
}

static int tas2770_set_bias_level(struct snd_soc_component *component,
Expand Down Expand Up @@ -110,6 +112,7 @@ static int tas2770_codec_resume(struct snd_soc_component *component)

if (tas2770->sdz_gpio) {
gpiod_set_value_cansleep(tas2770->sdz_gpio, 1);
usleep_range(1000, 2000);
} else {
ret = snd_soc_component_update_bits(component, TAS2770_PWR_CTRL,
TAS2770_PWR_CTRL_MASK,
Expand Down Expand Up @@ -510,8 +513,10 @@ static int tas2770_codec_probe(struct snd_soc_component *component)

tas2770->component = component;

if (tas2770->sdz_gpio)
if (tas2770->sdz_gpio) {
gpiod_set_value_cansleep(tas2770->sdz_gpio, 1);
usleep_range(1000, 2000);
}

tas2770_reset(tas2770);

Expand Down

0 comments on commit ce38a92

Please sign in to comment.