Skip to content

Commit

Permalink
NTB: Fix an error code in ntb_msit_probe()
Browse files Browse the repository at this point in the history
[ Upstream commit 319f83a ]

When the value of nm->isr_ctx is false, the value of ret is 0.
So, we set ret to -ENOMEM to indicate this error.

Clean up smatch warning:
drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing
error code 'ret'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Yang Li authored and gregkh committed Sep 22, 2021
1 parent e76ccbd commit ce660d6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/ntb/test/ntb_msi_test.c
Expand Up @@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)
if (ret)
goto remove_dbgfs;

if (!nm->isr_ctx)
if (!nm->isr_ctx) {
ret = -ENOMEM;
goto remove_dbgfs;
}

ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);

Expand Down

0 comments on commit ce660d6

Please sign in to comment.