Skip to content

Commit

Permalink
usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc
Browse files Browse the repository at this point in the history
We should verify the bound of the array to assure that host
may not manipulate the index to point past endpoint array.

Signed-off-by: Ma Ke <make_ruc2021@163.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
Link: https://lore.kernel.org/r/20230628081511.186850-1-make_ruc2021@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ma Ke authored and gregkh committed Jul 25, 2023
1 parent e032368 commit ce9daa2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/usb/gadget/udc/fsl_qe_udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1959,6 +1959,8 @@ static void ch9getstatus(struct qe_udc *udc, u8 request_type, u16 value,
} else if ((request_type & USB_RECIP_MASK) == USB_RECIP_ENDPOINT) {
/* Get endpoint status */
int pipe = index & USB_ENDPOINT_NUMBER_MASK;
if (pipe >= USB_MAX_ENDPOINTS)
goto stall;
struct qe_ep *target_ep = &udc->eps[pipe];
u16 usep;

Expand Down

0 comments on commit ce9daa2

Please sign in to comment.