Skip to content

Commit

Permalink
dpaa2-switch: do not enable the DPSW at probe time
Browse files Browse the repository at this point in the history
[ Upstream commit 042ad90 ]

We should not enable the switch interfaces at probe time since this is
trigged by the open callback. Remove the call dpsw_enable() which does
exactly this.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
IoanaCiornei authored and gregkh committed Sep 18, 2021
1 parent 653acdd commit d060cc2
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
Expand Up @@ -3231,12 +3231,6 @@ static int dpaa2_switch_probe(struct fsl_mc_device *sw_dev)
&ethsw->fq[i].napi, dpaa2_switch_poll,
NAPI_POLL_WEIGHT);

err = dpsw_enable(ethsw->mc_io, 0, ethsw->dpsw_handle);
if (err) {
dev_err(ethsw->dev, "dpsw_enable err %d\n", err);
goto err_free_netdev;
}

/* Setup IRQs */
err = dpaa2_switch_setup_irqs(sw_dev);
if (err)
Expand Down

0 comments on commit d060cc2

Please sign in to comment.