Skip to content

Commit

Permalink
video: fbdev: pvr2fb: initialize variables
Browse files Browse the repository at this point in the history
[ Upstream commit 8e1ba47 ]

clang static analysis reports this repesentative error

pvr2fb.c:1049:2: warning: 1st function call argument
  is an uninitialized value [core.CallAndMessage]
        if (*cable_arg)
        ^~~~~~~~~~~~~~~

Problem is that cable_arg depends on the input loop to
set the cable_arg[0].  If it does not, then some random
value from the stack is used.

A similar problem exists for output_arg.

So initialize cable_arg and output_arg.

Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200720191845.20115-1-trix@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
trixirt authored and gregkh committed Nov 5, 2020
1 parent 9745a32 commit d1c9ddc
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/video/fbdev/pvr2fb.c
Expand Up @@ -1028,6 +1028,8 @@ static int __init pvr2fb_setup(char *options)
if (!options || !*options)
return 0;

cable_arg[0] = output_arg[0] = 0;

while ((this_opt = strsep(&options, ","))) {
if (!*this_opt)
continue;
Expand Down

0 comments on commit d1c9ddc

Please sign in to comment.