Skip to content

Commit

Permalink
debugfs: do not attempt to create a new file before the filesystem is…
Browse files Browse the repository at this point in the history
… initalized

commit 5634856 upstream.

Some subsystems want to add debugfs files at early boot, way before
debugfs is initialized.  This seems to work somehow as the vfs layer
will not allow it to happen, but let's be explicit and test to ensure we
are properly up and running before allowing files to be created.

Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: stable <stable@vger.kernel.org>
Reported-by: Michael Walle <michael@walle.cc>
Reported-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210218100818.3622317-2-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
gregkh committed Mar 4, 2021
1 parent b874082 commit d288086
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions fs/debugfs/inode.c
Expand Up @@ -318,6 +318,9 @@ static struct dentry *start_creating(const char *name, struct dentry *parent)
if (!(debugfs_allow & DEBUGFS_ALLOW_API))
return ERR_PTR(-EPERM);

if (!debugfs_initialized())
return ERR_PTR(-ENOENT);

pr_debug("creating file '%s'\n", name);

if (IS_ERR(parent))
Expand Down

0 comments on commit d288086

Please sign in to comment.