Skip to content

Commit

Permalink
drm/amd/display: disable RCO for DCN314
Browse files Browse the repository at this point in the history
commit 85e41f1 upstream.

[Why]
RCO is causing error messages on some DCN314 systems

[How]
Force disable RCO for DCN314

Fixes: 17fbdbd ("drm/amd/display: Enable dcn314 DPP RCO")
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Daniel Miess <daniel.miess@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Daniel Miess authored and gregkh committed Aug 23, 2023
1 parent b2f599c commit d4008ea
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c
Expand Up @@ -296,7 +296,7 @@ static void dccg314_dpp_root_clock_control(
{
struct dcn_dccg *dccg_dcn = TO_DCN_DCCG(dccg);

if (dccg->dpp_clock_gated[dpp_inst] == clock_on)
if (dccg->dpp_clock_gated[dpp_inst] != clock_on)
return;

if (clock_on) {
Expand Down
4 changes: 4 additions & 0 deletions drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
Expand Up @@ -1933,6 +1933,10 @@ static bool dcn314_resource_construct(
dc->debug = debug_defaults_drv;
else
dc->debug = debug_defaults_diags;

/* Disable root clock optimization */
dc->debug.root_clock_optimization.u32All = 0;

// Init the vm_helper
if (dc->vm_helper)
vm_helper_init(dc->vm_helper, 16);
Expand Down

0 comments on commit d4008ea

Please sign in to comment.