Skip to content

Commit

Permalink
USB: legotower: fix logical error in recent commit
Browse files Browse the repository at this point in the history
commit b175d27 upstream.

Commit d9f0d82 ("USB: legousbtower: use usb_control_msg_recv()")
contained an elementary logical error.  The check of the return code
from the new usb_control_msg_recv() function was inverted.

Reported-and-tested-by: syzbot+9be25235b7a69b24d117@syzkaller.appspotmail.com
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20201208163042.GD1298255@rowland.harvard.edu
Fixes: d9f0d82 ("USB: legousbtower: use usb_control_msg_recv()")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
AlanStern authored and gregkh committed Dec 21, 2020
1 parent 2902e30 commit d483f5e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/misc/legousbtower.c
Expand Up @@ -797,7 +797,7 @@ static int tower_probe(struct usb_interface *interface, const struct usb_device_
&get_version_reply,
sizeof(get_version_reply),
1000, GFP_KERNEL);
if (!result) {
if (result) {
dev_err(idev, "get version request failed: %d\n", result);
retval = result;
goto error;
Expand Down

0 comments on commit d483f5e

Please sign in to comment.