Skip to content

Commit

Permalink
remoteproc: imx_dsp_rproc: Fix kernel test robot sparse warning
Browse files Browse the repository at this point in the history
[ Upstream commit 3c497f6 ]

This patch fixes the kernel test robot warning reported here:

https://lore.kernel.org/bpf/642f916b.pPIKZ%2Fl%2F%2Fbw8tvIH%25lkp@intel.com/T/

Fixes: 408ec1f ("remoteproc: imx_dsp_rproc: Add custom memory copy implementation for i.MX DSP Cores")
Link: https://lore.kernel.org/r/20230407161429.3973177-1-mathieu.poirier@linaro.org
Tested-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
mathieupoirier authored and gregkh committed May 24, 2023
1 parent b26d687 commit d51c013
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/remoteproc/imx_dsp_rproc.c
Expand Up @@ -727,12 +727,12 @@ static void imx_dsp_rproc_kick(struct rproc *rproc, int vqid)
* The IRAM is part of the HiFi DSP.
* According to hw specs only 32-bits writes are allowed.
*/
static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size)
static int imx_dsp_rproc_memcpy(void *dst, const void *src, size_t size)
{
void __iomem *dest = (void __iomem *)dst;
const u8 *src_byte = src;
const u32 *source = src;
u32 affected_mask;
u32 *dst = dest;
int i, q, r;
u32 tmp;

Expand All @@ -745,7 +745,7 @@ static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size)

/* copy data in units of 32 bits at a time */
for (i = 0; i < q; i++)
writel(source[i], &dst[i]);
writel(source[i], dest + i * 4);

if (r) {
affected_mask = GENMASK(8 * r, 0);
Expand Down Expand Up @@ -776,8 +776,8 @@ static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size)
*/
static int imx_dsp_rproc_memset(void *addr, u8 value, size_t size)
{
void __iomem *tmp_dst = (void __iomem *)addr;
u32 tmp_val = value;
u32 *tmp_dst = addr;
u32 affected_mask;
int q, r;
u32 tmp;
Expand Down

0 comments on commit d51c013

Please sign in to comment.