Skip to content

Commit

Permalink
dma-buf: Enable signaling on fence for selftests
Browse files Browse the repository at this point in the history
Here's enabling software signaling on fence for selftest.

Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220914164321.2156-4-Arvind.Yadav@amd.com
Signed-off-by: Christian König <christian.koenig@amd.com>
  • Loading branch information
ArvindYadavAMD authored and ChristianKoenigAMD committed Sep 16, 2022
1 parent c85d00d commit d62c43a
Show file tree
Hide file tree
Showing 4 changed files with 52 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/dma-buf/st-dma-fence-chain.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ static int sanitycheck(void *arg)
if (!chain)
err = -ENOMEM;

dma_fence_enable_sw_signaling(chain);

dma_fence_signal(f);
dma_fence_put(f);

Expand Down Expand Up @@ -143,6 +145,8 @@ static int fence_chains_init(struct fence_chains *fc, unsigned int count,
}

fc->tail = fc->chains[i];

dma_fence_enable_sw_signaling(fc->chains[i]);
}

fc->chain_length = i;
Expand Down
22 changes: 22 additions & 0 deletions drivers/dma-buf/st-dma-fence-unwrap.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ static int sanitycheck(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

array = mock_array(1, f);
if (!array)
return -ENOMEM;
Expand All @@ -124,12 +126,16 @@ static int unwrap_array(void *arg)
if (!f1)
return -ENOMEM;

dma_fence_enable_sw_signaling(f1);

f2 = mock_fence();
if (!f2) {
dma_fence_put(f1);
return -ENOMEM;
}

dma_fence_enable_sw_signaling(f2);

array = mock_array(2, f1, f2);
if (!array)
return -ENOMEM;
Expand Down Expand Up @@ -164,12 +170,16 @@ static int unwrap_chain(void *arg)
if (!f1)
return -ENOMEM;

dma_fence_enable_sw_signaling(f1);

f2 = mock_fence();
if (!f2) {
dma_fence_put(f1);
return -ENOMEM;
}

dma_fence_enable_sw_signaling(f2);

chain = mock_chain(f1, f2);
if (!chain)
return -ENOMEM;
Expand Down Expand Up @@ -204,12 +214,16 @@ static int unwrap_chain_array(void *arg)
if (!f1)
return -ENOMEM;

dma_fence_enable_sw_signaling(f1);

f2 = mock_fence();
if (!f2) {
dma_fence_put(f1);
return -ENOMEM;
}

dma_fence_enable_sw_signaling(f2);

array = mock_array(2, f1, f2);
if (!array)
return -ENOMEM;
Expand Down Expand Up @@ -248,12 +262,16 @@ static int unwrap_merge(void *arg)
if (!f1)
return -ENOMEM;

dma_fence_enable_sw_signaling(f1);

f2 = mock_fence();
if (!f2) {
err = -ENOMEM;
goto error_put_f1;
}

dma_fence_enable_sw_signaling(f2);

f3 = dma_fence_unwrap_merge(f1, f2);
if (!f3) {
err = -ENOMEM;
Expand Down Expand Up @@ -296,10 +314,14 @@ static int unwrap_merge_complex(void *arg)
if (!f1)
return -ENOMEM;

dma_fence_enable_sw_signaling(f1);

f2 = mock_fence();
if (!f2)
goto error_put_f1;

dma_fence_enable_sw_signaling(f2);

f3 = dma_fence_unwrap_merge(f1, f2);
if (!f3)
goto error_put_f2;
Expand Down
16 changes: 16 additions & 0 deletions drivers/dma-buf/st-dma-fence.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ static int sanitycheck(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

dma_fence_signal(f);
dma_fence_put(f);

Expand All @@ -117,6 +119,8 @@ static int test_signaling(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

if (dma_fence_is_signaled(f)) {
pr_err("Fence unexpectedly signaled on creation\n");
goto err_free;
Expand Down Expand Up @@ -190,6 +194,8 @@ static int test_late_add_callback(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

dma_fence_signal(f);

if (!dma_fence_add_callback(f, &cb.cb, simple_callback)) {
Expand Down Expand Up @@ -282,6 +288,8 @@ static int test_status(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

if (dma_fence_get_status(f)) {
pr_err("Fence unexpectedly has signaled status on creation\n");
goto err_free;
Expand All @@ -308,6 +316,8 @@ static int test_error(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

dma_fence_set_error(f, -EIO);

if (dma_fence_get_status(f)) {
Expand Down Expand Up @@ -337,6 +347,8 @@ static int test_wait(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

if (dma_fence_wait_timeout(f, false, 0) != -ETIME) {
pr_err("Wait reported complete before being signaled\n");
goto err_free;
Expand Down Expand Up @@ -379,6 +391,8 @@ static int test_wait_timeout(void *arg)
if (!wt.f)
return -ENOMEM;

dma_fence_enable_sw_signaling(wt.f);

if (dma_fence_wait_timeout(wt.f, false, 1) != -ETIME) {
pr_err("Wait reported complete before being signaled\n");
goto err_free;
Expand Down Expand Up @@ -458,6 +472,8 @@ static int thread_signal_callback(void *arg)
break;
}

dma_fence_enable_sw_signaling(f1);

rcu_assign_pointer(t->fences[t->id], f1);
smp_wmb();

Expand Down
10 changes: 10 additions & 0 deletions drivers/dma-buf/st-dma-resv.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ static int sanitycheck(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

dma_fence_signal(f);
dma_fence_put(f);

Expand All @@ -69,6 +71,8 @@ static int test_signaling(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

dma_resv_init(&resv);
r = dma_resv_lock(&resv, NULL);
if (r) {
Expand Down Expand Up @@ -114,6 +118,8 @@ static int test_for_each(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

dma_resv_init(&resv);
r = dma_resv_lock(&resv, NULL);
if (r) {
Expand Down Expand Up @@ -173,6 +179,8 @@ static int test_for_each_unlocked(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

dma_resv_init(&resv);
r = dma_resv_lock(&resv, NULL);
if (r) {
Expand Down Expand Up @@ -244,6 +252,8 @@ static int test_get_fences(void *arg)
if (!f)
return -ENOMEM;

dma_fence_enable_sw_signaling(f);

dma_resv_init(&resv);
r = dma_resv_lock(&resv, NULL);
if (r) {
Expand Down

0 comments on commit d62c43a

Please sign in to comment.