Skip to content

Commit

Permalink
ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xf…
Browse files Browse the repository at this point in the history
…er()

[ Upstream commit 4139f99 ]

It is possible for dma_request_chan() to return EPROBE_DEFER, which
means acdev->host->dev is not ready yet. At this point dev_err() will
have no output. Use dev_err_probe() instead.

Signed-off-by: Minjie Du <duminjie@vivo.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Minjie Du authored and gregkh committed Sep 13, 2023
1 parent fbf4048 commit d676d02
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/ata/pata_arasan_cf.c
Expand Up @@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work)
/* dma_request_channel may sleep, so calling from process context */
acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");
if (IS_ERR(acdev->dma_chan)) {
dev_err(acdev->host->dev, "Unable to get dma_chan\n");
dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
"Unable to get dma_chan\n");
acdev->dma_chan = NULL;
goto chan_request_fail;
}
Expand Down

0 comments on commit d676d02

Please sign in to comment.