Skip to content

Commit

Permalink
media: rockchip/rga: use pm_runtime_resume_and_get()
Browse files Browse the repository at this point in the history
[ Upstream commit 0314339 ]

Commit dd8088d ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.

Use the new API, in order to cleanup the error check logic.

Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
mchehab authored and gregkh committed Sep 15, 2021
1 parent 94d6aa2 commit dc49537
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 1 addition & 2 deletions drivers/media/platform/rockchip/rga/rga-buf.c
Expand Up @@ -79,9 +79,8 @@ static int rga_buf_start_streaming(struct vb2_queue *q, unsigned int count)
struct rockchip_rga *rga = ctx->rga;
int ret;

ret = pm_runtime_get_sync(rga->dev);
ret = pm_runtime_resume_and_get(rga->dev);
if (ret < 0) {
pm_runtime_put_noidle(rga->dev);
rga_buf_return_buffers(q, VB2_BUF_STATE_QUEUED);
return ret;
}
Expand Down
4 changes: 3 additions & 1 deletion drivers/media/platform/rockchip/rga/rga.c
Expand Up @@ -866,7 +866,9 @@ static int rga_probe(struct platform_device *pdev)
goto unreg_video_dev;
}

pm_runtime_get_sync(rga->dev);
ret = pm_runtime_resume_and_get(rga->dev);
if (ret < 0)
goto unreg_video_dev;

rga->version.major = (rga_read(rga, RGA_VERSION_INFO) >> 24) & 0xFF;
rga->version.minor = (rga_read(rga, RGA_VERSION_INFO) >> 20) & 0x0F;
Expand Down

0 comments on commit dc49537

Please sign in to comment.