Skip to content

Commit

Permalink
dm table: Remove BUG_ON(in_interrupt())
Browse files Browse the repository at this point in the history
[ Upstream commit e7b6241 ]

The BUG_ON(in_interrupt()) in dm_table_event() is a historic leftover from
a rework of the dm table code which changed the calling context.

Issuing a BUG for a wrong calling context is frowned upon and
in_interrupt() is deprecated and only covering parts of the wrong
contexts. The sanity check for the context is covered by
CONFIG_DEBUG_ATOMIC_SLEEP and other debug facilities already.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Thomas Gleixner authored and gregkh committed Dec 30, 2020
1 parent 8a89abb commit e124c5a
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/md/dm-table.c
Expand Up @@ -1320,12 +1320,6 @@ void dm_table_event_callback(struct dm_table *t,

void dm_table_event(struct dm_table *t)
{
/*
* You can no longer call dm_table_event() from interrupt
* context, use a bottom half instead.
*/
BUG_ON(in_interrupt());

mutex_lock(&_event_lock);
if (t->event_fn)
t->event_fn(t->event_context);
Expand Down

0 comments on commit e124c5a

Please sign in to comment.