Skip to content

Commit

Permalink
Revert "ext4: don't clear SB_RDONLY when remounting r/w until quota i…
Browse files Browse the repository at this point in the history
…s re-enabled"

commit 1b29243 upstream.

This reverts commit a44be64.

Link: https://lore.kernel.org/r/653b3359-2005-21b1-039d-c55ca4cffdcc@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
tytso authored and gregkh committed Jun 14, 2023
1 parent b016789 commit e7469a6
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions fs/ext4/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -6354,7 +6354,6 @@ static int __ext4_remount(struct fs_context *fc, struct super_block *sb)
struct ext4_mount_options old_opts;
ext4_group_t g;
int err = 0;
int enable_rw = 0;
#ifdef CONFIG_QUOTA
int enable_quota = 0;
int i, j;
Expand Down Expand Up @@ -6541,7 +6540,7 @@ static int __ext4_remount(struct fs_context *fc, struct super_block *sb)
if (err)
goto restore_opts;

enable_rw = 1;
sb->s_flags &= ~SB_RDONLY;
if (ext4_has_feature_mmp(sb)) {
err = ext4_multi_mount_protect(sb,
le64_to_cpu(es->s_mmp_block));
Expand Down Expand Up @@ -6588,9 +6587,6 @@ static int __ext4_remount(struct fs_context *fc, struct super_block *sb)
if (!test_opt(sb, BLOCK_VALIDITY) && sbi->s_system_blks)
ext4_release_system_zone(sb);

if (enable_rw)
sb->s_flags &= ~SB_RDONLY;

/*
* Reinitialize lazy itable initialization thread based on
* current settings
Expand Down

0 comments on commit e7469a6

Please sign in to comment.